https://chromiumcodereview.appspot.com/16206004/diff/2001/src/hydrogen-instructions.cc
File src/hydrogen-instructions.cc (right):
https://chromiumcodereview.appspot.com/16206004/diff/2001/src/hydrogen-instructions.cc#newcode1852
src/hydrogen-instructions.cc:1852: (r.IsSmi() &&
!a->Includes(Smi::kMinValue)) ||
On 2013/06/04 10:01:07, Sven Panne wrote:
On 2013/06/04 09:53:56, Sven Panne wrote:
> * Re-order back to a, then b test.
> * Introduce 'min_value = r.IsSmi() ? Smi::kMinValue() : kMinInt' and
use that.
>
> Same elsewhere.
Thinking about it: We have to avoid an idiv of 0x80000000 by
0x7fffffff, how can
this happen in the Smi case here?
Anyway, this flag setting business does not belong here at all,
anyway, the code
generation should look at the ranges IMHO.
You are right. I actually (temporarily) backed out changes for HMod; so
I should probably also remove this code again.
https://chromiumcodereview.appspot.com/16206004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
