https://codereview.chromium.org/16206004/diff/2001/src/hydrogen-instructions.h
File src/hydrogen-instructions.h (right):
https://codereview.chromium.org/16206004/diff/2001/src/hydrogen-instructions.h#newcode3380
src/hydrogen-instructions.h:3380: if (r.IsSmi() && CannotBothBeSmi()) {
A comment might be nice.
https://codereview.chromium.org/16206004/diff/2001/src/hydrogen.cc
File src/hydrogen.cc (right):
https://codereview.chromium.org/16206004/diff/2001/src/hydrogen.cc#newcode3475
src/hydrogen.cc:3475: !from.Equals(change->to())));
Why did you add the Equals() clause? This should already be guaranteed.
Is there extra value in the check here?
https://codereview.chromium.org/16206004/diff/2001/src/ia32/lithium-codegen-ia32.cc
File src/ia32/lithium-codegen-ia32.cc (right):
https://codereview.chromium.org/16206004/diff/2001/src/ia32/lithium-codegen-ia32.cc#newcode592
src/ia32/lithium-codegen-ia32.cc:592: HConstant* constant =
chunk_->LookupConstant(op);
why do you need to pass in the representation? Can't you get this from
op->hydrogen()->representation()?
https://codereview.chromium.org/16206004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
