lgtm with comments
https://codereview.chromium.org/15993012/diff/1/src/builtins.cc
File src/builtins.cc (right):
https://codereview.chromium.org/15993012/diff/1/src/builtins.cc#newcode212
src/builtins.cc:212: bool ignore_advice = false;
ignore_type_feedback is probably more accurate.
https://codereview.chromium.org/15993012/diff/1/src/builtins.cc#newcode217
src/builtins.cc:217: holey = (value > 0 && value <
JSObject::kInitialMaxFastElementArray);
Don't you mean >= 0? Or is the distinction important?
https://codereview.chromium.org/15993012/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
