Thanks for the comments Danno, I've addressed, and I noticed another issue,
see
comments.
--Michael
https://codereview.chromium.org/15993012/diff/1/src/builtins.cc
File src/builtins.cc (right):
https://codereview.chromium.org/15993012/diff/1/src/builtins.cc#newcode212
src/builtins.cc:212: bool ignore_advice = false;
On 2013/06/04 16:29:47, danno wrote:
ignore_type_feedback is probably more accurate.
Done.
https://codereview.chromium.org/15993012/diff/1/src/builtins.cc#newcode217
src/builtins.cc:217: holey = (value > 0 && value <
JSObject::kInitialMaxFastElementArray);
On 2013/06/04 16:29:47, danno wrote:
Don't you mean >= 0? Or is the distinction important?
I think it's important because if someone calls new Array(0), they
should get a packed array instead of a holey one.
But your comment brought to light a bug in this new code. I would choose
to ignore type feedback if the value == 0, which is wrong. I've prepped
a more careful initialization of ignore_type_feedback.
https://codereview.chromium.org/15993012/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
