Looks good.
Needing that mammoth condition in the lithium translator is unfortunate,
but in
the short term I don't see a way around it.
https://codereview.chromium.org/15769010/diff/1/src/ia32/lithium-codegen-ia32.cc
File src/ia32/lithium-codegen-ia32.cc (right):
https://codereview.chromium.org/15769010/diff/1/src/ia32/lithium-codegen-ia32.cc#newcode1246
src/ia32/lithium-codegen-ia32.cc:1246: int32_t divisor =
HConstant::cast(right)->Integer32Value();
even shorter: right->GetInteger32Constant()
https://codereview.chromium.org/15769010/diff/1/src/ia32/lithium-codegen-ia32.cc#newcode1321
src/ia32/lithium-codegen-ia32.cc:1321: __ test(left_reg,
Operand(left_reg));
Why this test? You already know that left_reg == kMinInt at this point.
https://codereview.chromium.org/15769010/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
