https://codereview.chromium.org/15769010/diff/11001/src/arm/lithium-arm.cc
File src/arm/lithium-arm.cc (right):
https://codereview.chromium.org/15769010/diff/11001/src/arm/lithium-arm.cc#newcode1502
src/arm/lithium-arm.cc:1502: UseFixedDouble(left, d1),
Technically not part of your patch but why are we using d1 and d2? The
hardfp abi will use d0 and d1 so this will generate some extra moves.
The same happens on ia32 so I presume there is (was?) a reason. Note
that on ia32 right is in d1 and left in d2 so only left will be moved
before the call. We could do the same for ARM.
https://codereview.chromium.org/15769010/diff/11001/src/arm/lithium-codegen-arm.cc
File src/arm/lithium-codegen-arm.cc (right):
https://codereview.chromium.org/15769010/diff/11001/src/arm/lithium-codegen-arm.cc#newcode1240
src/arm/lithium-codegen-arm.cc:1240: // Check for kMinInt % -1, sdiv
might signal an exception. We have to deopt
sdiv kMinInt, -1 will not trigger an exception but will return kMinInt.
(still not what you want)
https://codereview.chromium.org/15769010/diff/11001/src/arm/lithium-codegen-arm.cc#newcode1330
src/arm/lithium-codegen-arm.cc:1330: // TODO(svenpanne) Why do we need
scratch2 in addition to scratch?
I don't think we do either.
in fact you should be able to always do the sub first and then if you
care about -0 check if the result is 0 and left is negative (like it is
done when using sdiv)
https://codereview.chromium.org/15769010/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
