First rounds of comments. The implementation looks good. Can we make the
tests
more complicated, see comments?
https://codereview.chromium.org/15562008/diff/20001/src/objects.h
File src/objects.h (right):
https://codereview.chromium.org/15562008/diff/20001/src/objects.h#newcode8831
src/objects.h:8831: // [next]: linked list of typed arrays over the same
array buffer.
should be called weak_next
https://codereview.chromium.org/15562008/diff/20001/test/cctest/test-weaktypedarrays.cc
File test/cctest/test-weaktypedarrays.cc (right):
https://codereview.chromium.org/15562008/diff/20001/test/cctest/test-weaktypedarrays.cc#newcode134
test/cctest/test-weaktypedarrays.cc:134: "var ab2 = new
ArrayBuffer(256);");
indent
https://codereview.chromium.org/15562008/diff/20001/test/cctest/test-weaktypedarrays.cc#newcode167
test/cctest/test-weaktypedarrays.cc:167:
Can we add a third typed array to the week list and delete, once the
first, once the middle, and once the third element? To get all corner
cases of the list implementation.
https://codereview.chromium.org/15562008/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
