Thanks a lot for review - please take another look.
https://codereview.chromium.org/15562008/diff/20001/src/objects-visiting-inl.h
File src/objects-visiting-inl.h (right):
https://codereview.chromium.org/15562008/diff/20001/src/objects-visiting-inl.h#newcode125
src/objects-visiting-inl.h:125:
On 2013/06/06 09:53:18, Michael Starzinger wrote:
nit: Add a second empty newline.
Done.
https://codereview.chromium.org/15562008/diff/20001/src/objects-visiting-inl.h#newcode143
src/objects-visiting-inl.h:143:
On 2013/06/06 09:53:18, Michael Starzinger wrote:
nit: Drop the third empty newline.
Done.
https://codereview.chromium.org/15562008/diff/20001/src/objects-visiting-inl.h#newcode199
src/objects-visiting-inl.h:199:
On 2013/06/06 09:53:18, Michael Starzinger wrote:
nit: Drop the second empty newline.
Done.
https://codereview.chromium.org/15562008/diff/20001/src/objects-visiting-inl.h#newcode470
src/objects-visiting-inl.h:470:
On 2013/06/06 09:53:18, Michael Starzinger wrote:
nit: Add a second empty newline.
Done.
https://codereview.chromium.org/15562008/diff/20001/src/objects-visiting.cc
File src/objects-visiting.cc (right):
https://codereview.chromium.org/15562008/diff/20001/src/objects-visiting.cc#newcode154
src/objects-visiting.cc:154: return GetVisitorIdForSize(kVisitJSObject,
On 2013/06/06 09:53:18, Michael Starzinger wrote:
nit: Indentation is off.
Done.
https://codereview.chromium.org/15562008/diff/20001/src/objects.h
File src/objects.h (right):
https://codereview.chromium.org/15562008/diff/20001/src/objects.h#newcode8831
src/objects.h:8831: // [next]: linked list of typed arrays over the same
array buffer.
On 2013/06/06 09:33:35, Hannes Payer wrote:
should be called weak_next
Done.
https://codereview.chromium.org/15562008/diff/20001/test/cctest/test-weaktypedarrays.cc
File test/cctest/test-weaktypedarrays.cc (right):
https://codereview.chromium.org/15562008/diff/20001/test/cctest/test-weaktypedarrays.cc#newcode134
test/cctest/test-weaktypedarrays.cc:134: "var ab2 = new
ArrayBuffer(256);");
On 2013/06/06 09:33:35, Hannes Payer wrote:
indent
Done.
https://codereview.chromium.org/15562008/diff/20001/test/cctest/test-weaktypedarrays.cc#newcode167
test/cctest/test-weaktypedarrays.cc:167:
Done.
I have added this to *FromScript tests - it is easier to create and
clean up references at will in that context.
On 2013/06/06 09:33:35, Hannes Payer wrote:
Can we add a third typed array to the week list and delete, once the
first, once
the middle, and once the third element? To get all corner cases of the
list
implementation.
https://codereview.chromium.org/15562008/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
