LGTM with nits
https://codereview.chromium.org/15300018/diff/3001/src/ast.h
File src/ast.h (right):
https://codereview.chromium.org/15300018/diff/3001/src/ast.h#newcode860
src/ast.h:860: void Initialize(Expression* each,
Nit: doesn't this fit on one line?
https://codereview.chromium.org/15300018/diff/3001/src/full-codegen.cc
File src/full-codegen.cc (right):
https://codereview.chromium.org/15300018/diff/3001/src/full-codegen.cc#newcode1395
src/full-codegen.cc:1395: void
FullCodeGenerator::VisitForOfStatement(ForOfStatement* stmt) {
Normally I'd want a TODO here, but since that's in flight already it
doesn't really matter...
https://codereview.chromium.org/15300018/diff/3001/src/parser.cc
File src/parser.cc (left):
https://codereview.chromium.org/15300018/diff/3001/src/parser.cc#oldcode2946
src/parser.cc:2946: if (loop) loop->Initialize(expression, enumerable,
body);
Weird, what was the purpose of this condition?
https://codereview.chromium.org/15300018/diff/3001/src/scanner.h
File src/scanner.h (right):
https://codereview.chromium.org/15300018/diff/3001/src/scanner.h#newcode181
src/scanner.h:181: bool is_contextual_keyword(Vector<const char>
keyword) {
Yes, that's better. :)
https://codereview.chromium.org/15300018/diff/3001/test/mjsunit/harmony/iteration-syntax.js
File test/mjsunit/harmony/iteration-syntax.js (right):
https://codereview.chromium.org/15300018/diff/3001/test/mjsunit/harmony/iteration-syntax.js#newcode50
test/mjsunit/harmony/iteration-syntax.js:50: // Alack, this appears to
be valid.
However, "for (of x)" or "for (of of)" shouldn't be.
https://codereview.chromium.org/15300018/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
