On 2013/06/06 13:23:47, wingo wrote:
On 2013/06/06 09:36:34, Michael Starzinger wrote:
> Just one drive-by comment.
>
> https://codereview.chromium.org/15300018/diff/3001/src/ast.h
> File src/ast.h (right):
>
> https://codereview.chromium.org/15300018/diff/3001/src/ast.h#newcode2839
> src/ast.h:2839: default:
> Please avoid default cases in switches over enums.
Unhappily, without this case GCC complains about "control reached end of
non-void function".
Nevertheless, don't use the "default" case, just move its contents to the
end of
the function. Now we *and* GCC are happy. :)
https://codereview.chromium.org/15300018/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
