LGTM with a nit (drive-by, after heated discussions ;-)
https://codereview.chromium.org/16268009/diff/5001/src/hydrogen-instructions.cc
File src/hydrogen-instructions.cc (right):
https://codereview.chromium.org/16268009/diff/5001/src/hydrogen-instructions.cc#newcode1326
src/hydrogen-instructions.cc:1326: Range* result = new(zone)
Range(lower, upper);
Shorter and more readable:
new(zone) Range(spans_zero ? 0 : Min(Abs(lower), Abs(upper)),
Max(Abs(lower), Abs(upper)))
https://codereview.chromium.org/16268009/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
