LGTM with one more comment.
https://chromiumcodereview.appspot.com/16268009/diff/16001/src/hydrogen-instructions.cc
File src/hydrogen-instructions.cc (right):
https://chromiumcodereview.appspot.com/16268009/diff/16001/src/hydrogen-instructions.cc#newcode1320
src/hydrogen-instructions.cc:1320: int abs_lower = lower == kMinInt ?
kMaxInt : abs(kMinInt);
I think you need to do this same trick for abs_upper, or is it
guaranteed that upper != kMinInt?
https://chromiumcodereview.appspot.com/16268009/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
