Revision: 15065
Author:   [email protected]
Date:     Tue Jun 11 07:45:17 2013
Log:      Disable --harmony -> --harmony-generators implication

A GC-related bug has started showing up after r15060 that unfortunately
I haven't been able to reproduce.  Disable generators by default for the
Canary push.

[email protected]
BUG=

Review URL: https://codereview.chromium.org/16638011
http://code.google.com/p/v8/source/detail?r=15065

Modified:
 /branches/bleeding_edge/src/flag-definitions.h
 /branches/bleeding_edge/test/mjsunit/harmony/iteration-semantics.js
 /branches/bleeding_edge/test/mjsunit/mjsunit.status

=======================================
--- /branches/bleeding_edge/src/flag-definitions.h      Thu Jun  6 07:38:26 2013
+++ /branches/bleeding_edge/src/flag-definitions.h      Tue Jun 11 07:45:17 2013
@@ -178,7 +178,8 @@
 DEFINE_implication(harmony, harmony_proxies)
 DEFINE_implication(harmony, harmony_collections)
 DEFINE_implication(harmony, harmony_observation)
-DEFINE_implication(harmony, harmony_generators)
+// TODO(wingo): Re-enable when GC bug that appeared in r15060 is gone.
+// DEFINE_implication(harmony, harmony_generators)
 DEFINE_implication(harmony, harmony_iteration)
 DEFINE_implication(harmony_modules, harmony_scoping)
 DEFINE_implication(harmony_observation, harmony_collections)
=======================================
--- /branches/bleeding_edge/test/mjsunit/harmony/iteration-semantics.js Fri Jun 7 04:12:21 2013 +++ /branches/bleeding_edge/test/mjsunit/harmony/iteration-semantics.js Tue Jun 11 07:45:17 2013
@@ -25,7 +25,7 @@
 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.

-// Flags: --harmony
+// Flags: --harmony --harmony-generators

 // Test for-of semantics.

=======================================
--- /branches/bleeding_edge/test/mjsunit/mjsunit.status Wed May 29 01:29:25 2013 +++ /branches/bleeding_edge/test/mjsunit/mjsunit.status Tue Jun 11 07:45:17 2013
@@ -46,6 +46,10 @@
 # Deferred stack trace formatting is temporarily disabled.
 stack-traces-gc: PASS || FAIL

+##############################################################################
+# TODO(wingo): Re-enable when GC bug from r15060 is solved.
+harmony/generators-iteration: SKIP
+
##############################################################################
 # Too slow in debug mode with --stress-opt mode.
 compiler/regress-stacktrace-methods: PASS, SKIP if $mode == debug

--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.


Reply via email to