On 2013/06/12 06:57:36, Sven Panne wrote:
DBC...
https://chromiumcodereview.appspot.com/15709020/diff/1/src/assert-scope.h
File src/assert-scope.h (right):
https://chromiumcodereview.appspot.com/15709020/diff/1/src/assert-scope.h#newcode81
src/assert-scope.h:81: enum AcquireAssertDataMode { CREATE_IF_ABSENT,
NULL_IF_ABSENT };
This is getting a little bit confusing... I think that instead of
introducing
this enum, we should actually just split AssertData() into 2 methods: One
for
retrieving PerThreadAssertData from TLS and one putting it into TLS.
IsAllowed
simply uses the first method, while the PerThreadAssertScopeBase
constructor
uses a combination of the 2 methods.
http://www.refactoring.com/catalog/replaceParameterWithExplicitMethods.html
Changed as suggested. Please take another look.
https://codereview.chromium.org/15709020/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
