On 2013/06/12 09:41:16, Sven Panne wrote:
https://chromiumcodereview.appspot.com/15709020/diff/5001/src/assert-scope.h
File src/assert-scope.h (right):
https://chromiumcodereview.appspot.com/15709020/diff/5001/src/assert-scope.h#newcode81
src/assert-scope.h:81: enum AcquireAssertDataMode { CREATE_IF_ABSENT,
NULL_IF_ABSENT };
Nuke this.
https://chromiumcodereview.appspot.com/15709020/diff/5001/src/assert-scope.h#newcode87
src/assert-scope.h:87: Thread::SetThreadLocal(thread_local_key, data_);
Put the TLS write into a private method and use it here...
https://chromiumcodereview.appspot.com/15709020/diff/5001/src/assert-scope.h#newcode98
src/assert-scope.h:98: Thread::SetThreadLocal(thread_local_key, NULL);
... and here.
I addressed the comments.
https://codereview.chromium.org/15709020/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
