LGTM if this consistenly un-flakes things. Can we do something similar for
CollectCpuProfile?
https://chromiumcodereview.appspot.com/16932003/diff/1/test/cctest/profiler-extension.cc
File test/cctest/profiler-extension.cc (right):
https://chromiumcodereview.appspot.com/16932003/diff/1/test/cctest/profiler-extension.cc#newcode46
test/cctest/profiler-extension.cc:46: CHECK(false);
Using FATAL with a description is more helpful and clearer.
https://chromiumcodereview.appspot.com/16932003/diff/1/test/cctest/profiler-extension.cc#newcode55
test/cctest/profiler-extension.cc:55: if (args.Length() > 0)
Bonus points for using a ternary ?: here...
https://chromiumcodereview.appspot.com/16932003/diff/1/test/cctest/profiler-extension.cc#newcode66
test/cctest/profiler-extension.cc:66: if (args.Length() > 0)
... and here. :-)
https://chromiumcodereview.appspot.com/16932003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
