https://codereview.chromium.org/16932003/diff/1/test/cctest/profiler-extension.cc
File test/cctest/profiler-extension.cc (right):
https://codereview.chromium.org/16932003/diff/1/test/cctest/profiler-extension.cc#newcode46
test/cctest/profiler-extension.cc:46: CHECK(false);
On 2013/06/13 09:19:12, Sven Panne wrote:
Using FATAL with a description is more helpful and clearer.
Done.
https://codereview.chromium.org/16932003/diff/1/test/cctest/profiler-extension.cc#newcode55
test/cctest/profiler-extension.cc:55: if (args.Length() > 0)
On 2013/06/13 09:19:12, Sven Panne wrote:
Bonus points for using a ternary ?: here...
Done.
https://codereview.chromium.org/16932003/diff/1/test/cctest/profiler-extension.cc#newcode66
test/cctest/profiler-extension.cc:66: if (args.Length() > 0)
On 2013/06/13 09:19:12, Sven Panne wrote:
... and here. :-)
Done.
https://codereview.chromium.org/16932003/diff/1/test/cctest/profiler-extension.h
File test/cctest/profiler-extension.h (right):
https://codereview.chromium.org/16932003/diff/1/test/cctest/profiler-extension.h#newcode30
test/cctest/profiler-extension.h:30:
On 2013/06/13 09:11:35, Yury Semikhatsky wrote:
#include "v8.h" ?
Done.
https://codereview.chromium.org/16932003/diff/1/test/cctest/profiler-extension.h#newcode39
test/cctest/profiler-extension.h:39: static v8::Handle<v8::Value>
StartProfiling(const v8::Arguments& args);
On 2013/06/13 09:11:35, Yury Semikhatsky wrote:
These two functions can be private.
Done.
https://codereview.chromium.org/16932003/diff/1/test/cctest/test-cpu-profiler.cc
File test/cctest/test-cpu-profiler.cc (right):
https://codereview.chromium.org/16932003/diff/1/test/cctest/test-cpu-profiler.cc#newcode937
test/cctest/test-cpu-profiler.cc:937: v8::Local<v8::Context> context =
v8::Context::New(isolate, &config);
On 2013/06/13 09:11:35, Yury Semikhatsky wrote:
Can you continue using LocalContext for consistency? Note that its
constructor
accepts v8::ExtensionConfiguration as first argument.
Done.
https://codereview.chromium.org/16932003/diff/1/test/cctest/test-cpu-profiler.cc#newcode972
test/cctest/test-cpu-profiler.cc:972: v8::Local<v8::Context> context =
v8::Context::New(isolate, &config);
On 2013/06/13 09:11:35, Yury Semikhatsky wrote:
Ditto.
Done.
https://codereview.chromium.org/16932003/diff/1/test/cctest/test-profile-generator.cc
File test/cctest/test-profile-generator.cc (right):
https://codereview.chromium.org/16932003/diff/1/test/cctest/test-profile-generator.cc#newcode34
test/cctest/test-profile-generator.cc:34: #include
"profiler-extension.h"
On 2013/06/13 09:11:35, Yury Semikhatsky wrote:
Should be before #include "../include/v8-profiler.h"
Done.
https://codereview.chromium.org/16932003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
