Yeah, the spec requires next to be a method on the prototype so we need
private
state.
Andreas, I'm in favor to exposing private names to embedders if we cannot
get
TC39 to support them.
Is it OK to trigger this based on --harmony_iteration? Is it OK that this
needs
--harmony_symbol to also be specified? Maybe a new flag would be cleaner do
that
it doesn't fail when --harmony_symbols is not enabled?
https://codereview.chromium.org/16848004/diff/1/src/array-iterator.js
File src/array-iterator.js (right):
https://codereview.chromium.org/16848004/diff/1/src/array-iterator.js#newcode36
src/array-iterator.js:36: var s = $Symbol();
On 2013/06/13 04:26:18, wingo wrote:
Is this variable used?
Done.
https://codereview.chromium.org/16848004/diff/1/src/array-iterator.js#newcode72
src/array-iterator.js:72:
On 2013/06/13 08:22:02, rossberg wrote:
Nit: duplicated empty line
Done.
https://codereview.chromium.org/16848004/diff/1/test/mjsunit/harmony/array-iterator.js
File test/mjsunit/harmony/array-iterator.js (right):
https://codereview.chromium.org/16848004/diff/1/test/mjsunit/harmony/array-iterator.js#newcode29
test/mjsunit/harmony/array-iterator.js:29:
On 2013/06/13 08:22:02, rossberg wrote:
Can you add some tests using for-of?
I was planning to. I just wanted to send this out before I left the
office yesterday.
https://codereview.chromium.org/16848004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
