LGTM with comments.
https://codereview.chromium.org/16950004/diff/1/src/hydrogen.cc
File src/hydrogen.cc (right):
https://codereview.chromium.org/16950004/diff/1/src/hydrogen.cc#newcode6105
src/hydrogen.cc:6105: new(zone()) HConstant(expr->literal_index(),
Representation::Smi())));
I would just not specify a particular representation in HConstant
constructor and let the inferencer figure it out.
https://codereview.chromium.org/16950004/diff/1/src/ia32/full-codegen-ia32.cc
File src/ia32/full-codegen-ia32.cc (right):
https://codereview.chromium.org/16950004/diff/1/src/ia32/full-codegen-ia32.cc#newcode1797
src/ia32/full-codegen-ia32.cc:1797: if (false &&
IsFastObjectElementsKind(constant_elements_kind)) {
This "false" looks like a debugging left-over.
https://codereview.chromium.org/16950004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
