https://codereview.chromium.org/17418003/diff/1/src/objects-visiting-inl.h
File src/objects-visiting-inl.h (right):
https://codereview.chromium.org/17418003/diff/1/src/objects-visiting-inl.h#newcode237
src/objects-visiting-inl.h:237: if (object->IsConsString() &&
ConsString::cast(object)->IsFlat()) {
I don't think this is the correct place to do the short-circuit strings.
It's not feasible to add a special check for IsConstString() to every
iterator that could potentially encounter a cons string. This needs to
be done by the actual visitor function. I'll look into a cleaner
solution for this.
https://codereview.chromium.org/17418003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
