On 2013/06/20 12:40:34, Michael Starzinger wrote:
https://codereview.chromium.org/17418003/diff/5001/src/objects-visiting-inl.h
File src/objects-visiting-inl.h (right):
https://codereview.chromium.org/17418003/diff/5001/src/objects-visiting-inl.h#newcode240
src/objects-visiting-inl.h:240: StaticVisitor::VisitPointer(heap,
rinfo->target_object_address());
Yes, this approach will work. But it requires a trailing update of the
target
object, because on some architectures you are not going to get a direct
pointer
into the code because the embedded object is stored split accross several
instructions. Something like the following is needed.
Look at PointersUpdatingVisitor::VisitEmbeddedPointer() for an example of
how
this can be done.
uploaded another patch set :)
https://codereview.chromium.org/17418003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
