LGTM with a nit.
https://codereview.chromium.org/17068006/diff/3001/include/v8.h
File include/v8.h (right):
https://codereview.chromium.org/17068006/diff/3001/include/v8.h#newcode5938
include/v8.h:5938: #ifdef V8_ENABLE_CHECKS
Moving the #ifdef to the CheckInitialized declaration (would become an
inline function with an empty body in release mode then) is probably a
bit nicer, reducing macro usage is almost always a good thing.
https://codereview.chromium.org/17068006/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
