Addressed comments. Landing.
https://codereview.chromium.org/17068006/diff/3001/include/v8.h
File include/v8.h (right):
https://codereview.chromium.org/17068006/diff/3001/include/v8.h#newcode5938
include/v8.h:5938: #ifdef V8_ENABLE_CHECKS
On 2013/06/24 08:23:48, Sven Panne wrote:
Moving the #ifdef to the CheckInitialized declaration (would become an
inline
function with an empty body in release mode then) is probably a bit
nicer,
reducing macro usage is almost always a good thing.
Done. As discussed offline, this will require the embedder to be
compiled with the same value of V8_ENABLE_CHECKS as V8 itself, otherwise
linking will fail. In case that ever bites us, then this can be fixed by
always using an inline wrapper and renaming the implementation to
"CheckInitializedImpl" so that this symbol is always available.
https://codereview.chromium.org/17068006/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
