LGTM with comment

https://codereview.chromium.org/17444011/diff/1/src/ast.h
File src/ast.h (right):

https://codereview.chromium.org/17444011/diff/1/src/ast.h#newcode405
src/ast.h:405:
Nit: I'd remove that empty line

https://codereview.chromium.org/17444011/diff/1/src/ia32/lithium-codegen-ia32.cc
File src/ia32/lithium-codegen-ia32.cc (right):

https://codereview.chromium.org/17444011/diff/1/src/ia32/lithium-codegen-ia32.cc#newcode2243
src/ia32/lithium-codegen-ia32.cc:2243: if (!info()->IsStub()) {
This seems redundant, given that DeoptimizeIf already makes the
distinction. (Same for other platforms)

https://codereview.chromium.org/17444011/

--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.


Reply via email to