LGTM with nits.
https://codereview.chromium.org/17444011/diff/15001/src/ast.cc
File src/ast.cc (right):
https://codereview.chromium.org/17444011/diff/15001/src/ast.cc#newcode292
src/ast.cc:292: // TODO(oli) If this Operation is used in a test
context, then the expression
nit: the identifier in the parentheses should be the @chromium.org
username, so "olivf" in your case.
https://codereview.chromium.org/17444011/diff/15001/src/ast.cc#newcode293
src/ast.cc:293: // has a ToBool stub and we want to collect this
information. However the
nit: s/ToBool/ToBoolean/
https://codereview.chromium.org/17444011/diff/15001/src/ast.h
File src/ast.h (right):
https://codereview.chromium.org/17444011/diff/15001/src/ast.h#newcode398
src/ast.h:398: byte to_boolean_types_;
nit: the style guide forbids non-private fields. Use a protected setter,
leave the field itself private.
https://codereview.chromium.org/17444011/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
