Revision: 15300
Author: [email protected]
Date: Mon Jun 24 07:26:32 2013
Log: Removed some useless/dead code regarding CompileTimeValues.
[email protected]
Review URL: https://codereview.chromium.org/17580018
http://code.google.com/p/v8/source/detail?r=15300
Modified:
/branches/bleeding_edge/src/arm/full-codegen-arm.cc
/branches/bleeding_edge/src/ia32/full-codegen-ia32.cc
/branches/bleeding_edge/src/mips/full-codegen-mips.cc
/branches/bleeding_edge/src/parser.cc
/branches/bleeding_edge/src/parser.h
/branches/bleeding_edge/src/x64/full-codegen-x64.cc
=======================================
--- /branches/bleeding_edge/src/arm/full-codegen-arm.cc Mon Jun 24 03:37:59
2013
+++ /branches/bleeding_edge/src/arm/full-codegen-arm.cc Mon Jun 24 07:26:32
2013
@@ -1829,10 +1829,7 @@
Expression* subexpr = subexprs->at(i);
// If the subexpression is a literal or a simple materialized literal
it
// is already set in the cloned array.
- if (subexpr->AsLiteral() != NULL ||
- CompileTimeValue::IsCompileTimeValue(subexpr)) {
- continue;
- }
+ if (CompileTimeValue::IsCompileTimeValue(subexpr)) continue;
if (!result_saved) {
__ push(r0);
=======================================
--- /branches/bleeding_edge/src/ia32/full-codegen-ia32.cc Mon Jun 24
03:37:59 2013
+++ /branches/bleeding_edge/src/ia32/full-codegen-ia32.cc Mon Jun 24
07:26:32 2013
@@ -1782,10 +1782,7 @@
Expression* subexpr = subexprs->at(i);
// If the subexpression is a literal or a simple materialized literal
it
// is already set in the cloned array.
- if (subexpr->AsLiteral() != NULL ||
- CompileTimeValue::IsCompileTimeValue(subexpr)) {
- continue;
- }
+ if (CompileTimeValue::IsCompileTimeValue(subexpr)) continue;
if (!result_saved) {
__ push(eax); // array literal.
=======================================
--- /branches/bleeding_edge/src/mips/full-codegen-mips.cc Thu Jun 20
16:43:10 2013
+++ /branches/bleeding_edge/src/mips/full-codegen-mips.cc Mon Jun 24
07:26:32 2013
@@ -1834,10 +1834,7 @@
Expression* subexpr = subexprs->at(i);
// If the subexpression is a literal or a simple materialized literal
it
// is already set in the cloned array.
- if (subexpr->AsLiteral() != NULL ||
- CompileTimeValue::IsCompileTimeValue(subexpr)) {
- continue;
- }
+ if (CompileTimeValue::IsCompileTimeValue(subexpr)) continue;
if (!result_saved) {
__ push(v0); // array literal
=======================================
--- /branches/bleeding_edge/src/parser.cc Mon Jun 24 03:37:59 2013
+++ /branches/bleeding_edge/src/parser.cc Mon Jun 24 07:26:32 2013
@@ -3732,18 +3732,6 @@
MaterializedLiteral* lit = expression->AsMaterializedLiteral();
return lit != NULL && lit->is_simple();
}
-
-
-bool CompileTimeValue::ArrayLiteralElementNeedsInitialization(
- Expression* value) {
- // If value is a literal the property value is already set in the
- // boilerplate object.
- if (value->AsLiteral() != NULL) return false;
- // If value is a materialized literal the property value is already set
- // in the boilerplate object if it is simple.
- if (CompileTimeValue::IsCompileTimeValue(value)) return false;
- return true;
-}
Handle<FixedArray> CompileTimeValue::GetValue(Expression* expression) {
=======================================
--- /branches/bleeding_edge/src/parser.h Wed Jun 12 05:37:44 2013
+++ /branches/bleeding_edge/src/parser.h Mon Jun 24 07:26:32 2013
@@ -888,8 +888,6 @@
static bool IsCompileTimeValue(Expression* expression);
- static bool ArrayLiteralElementNeedsInitialization(Expression* value);
-
// Get the value as a compile time value.
static Handle<FixedArray> GetValue(Expression* expression);
=======================================
--- /branches/bleeding_edge/src/x64/full-codegen-x64.cc Mon Jun 24 03:37:59
2013
+++ /branches/bleeding_edge/src/x64/full-codegen-x64.cc Mon Jun 24 07:26:32
2013
@@ -1806,10 +1806,7 @@
Expression* subexpr = subexprs->at(i);
// If the subexpression is a literal or a simple materialized literal
it
// is already set in the cloned array.
- if (subexpr->AsLiteral() != NULL ||
- CompileTimeValue::IsCompileTimeValue(subexpr)) {
- continue;
- }
+ if (CompileTimeValue::IsCompileTimeValue(subexpr)) continue;
if (!result_saved) {
__ push(rax); // array literal
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
