Revision: 15301
Author: [email protected]
Date: Mon Jun 24 07:34:07 2013
Log: Fix ugly typo in HValue::UpdateRepresentation.
[email protected]
TEST=mjsunit/math-min-max --extra-flags="--gc-interval=500"
Review URL: https://codereview.chromium.org/17580019
http://code.google.com/p/v8/source/detail?r=15301
Modified:
/branches/bleeding_edge/src/hydrogen-instructions.cc
/branches/bleeding_edge/src/hydrogen-instructions.h
/branches/bleeding_edge/src/hydrogen.cc
/branches/bleeding_edge/src/hydrogen.h
=======================================
--- /branches/bleeding_edge/src/hydrogen-instructions.cc Fri Jun 21
05:50:02 2013
+++ /branches/bleeding_edge/src/hydrogen-instructions.cc Mon Jun 24
07:34:07 2013
@@ -128,7 +128,7 @@
const char* reason) {
Representation r = representation();
if (new_rep.is_more_general_than(r)) {
- if (CheckFlag(kCannotBeTagged) && r.IsTagged()) return;
+ if (CheckFlag(kCannotBeTagged) && new_rep.IsTagged()) return;
if (FLAG_trace_representation) {
PrintF("Changing #%d %s representation %s -> %s based on %s\n",
id(), Mnemonic(), r.Mnemonic(), new_rep.Mnemonic(), reason);
=======================================
--- /branches/bleeding_edge/src/hydrogen-instructions.h Fri Jun 21 04:10:06
2013
+++ /branches/bleeding_edge/src/hydrogen-instructions.h Mon Jun 24 07:34:07
2013
@@ -890,10 +890,10 @@
Representation representation() const { return representation_; }
void ChangeRepresentation(Representation r) {
ASSERT(CheckFlag(kFlexibleRepresentation));
+ ASSERT(!CheckFlag(kCannotBeTagged) || !r.IsTagged());
RepresentationChanged(r);
representation_ = r;
- if (r.IsTagged() ||
- (r.IsDouble() && CheckFlag(kCannotBeTagged))) {
+ if (r.IsTagged()) {
// Tagged is the bottom of the lattice, don't go any further.
ClearFlag(kFlexibleRepresentation);
}
=======================================
--- /branches/bleeding_edge/src/hydrogen.cc Mon Jun 24 06:37:46 2013
+++ /branches/bleeding_edge/src/hydrogen.cc Mon Jun 24 07:34:07 2013
@@ -4649,12 +4649,6 @@
}
}
}
-
-
-void HOptimizedGraphBuilder::AddPhi(HPhi* instr) {
- ASSERT(current_block() != NULL);
- current_block()->AddPhi(instr);
-}
void HOptimizedGraphBuilder::PushAndAdd(HInstruction* instr) {
=======================================
--- /branches/bleeding_edge/src/hydrogen.h Mon Jun 24 06:25:44 2013
+++ /branches/bleeding_edge/src/hydrogen.h Mon Jun 24 07:34:07 2013
@@ -1624,8 +1624,6 @@
// Visit a list of expressions from left to right, each in a value
context.
void VisitExpressions(ZoneList<Expression*>* exprs);
- void AddPhi(HPhi* phi);
-
void PushAndAdd(HInstruction* instr);
// Remove the arguments from the bailout environment and emit
instructions
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
