not lgtm, now that we have a reproduction case for this issue there should
be a
test.
https://codereview.chromium.org/17616002/diff/1/src/heap-snapshot-generator.cc
File src/heap-snapshot-generator.cc (right):
https://codereview.chromium.org/17616002/diff/1/src/heap-snapshot-generator.cc#newcode1249
src/heap-snapshot-generator.cc:1249: if (Object* getter =
accessors->getter()) {
Can this ever be NULL?
https://codereview.chromium.org/17616002/diff/1/src/heap-snapshot-generator.cc#newcode1253
src/heap-snapshot-generator.cc:1253: if (Object* setter =
accessors->setter()) {
And this? I'd think that it is either oddball or some object as both
fields are initialized with OddBall values in
https://code.google.com/p/chromium/codesearch#chromium/src/v8/src/heap.cc&q=AllocateAccessorPair&sq=package:chromium&type=cs&l=2360
https://codereview.chromium.org/17616002/diff/1/src/heap-snapshot-generator.cc#newcode1415
src/heap-snapshot-generator.cc:1415: if (getter && !getter->IsOddball())
{
Ditto.
https://codereview.chromium.org/17616002/diff/1/src/heap-snapshot-generator.cc#newcode1419
src/heap-snapshot-generator.cc:1419: if (setter && !setter->IsOddball())
{
Ditto.
https://codereview.chromium.org/17616002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
