https://codereview.chromium.org/17616002/diff/1/src/heap-snapshot-generator.cc
File src/heap-snapshot-generator.cc (right):
https://codereview.chromium.org/17616002/diff/1/src/heap-snapshot-generator.cc#newcode1249
src/heap-snapshot-generator.cc:1249: if (Object* getter =
accessors->getter()) {
On 2013/06/24 19:00:37, Yury Semikhatsky wrote:
Can this ever be NULL?
Done.
https://codereview.chromium.org/17616002/diff/1/src/heap-snapshot-generator.cc#newcode1253
src/heap-snapshot-generator.cc:1253: if (Object* setter =
accessors->setter()) {
On 2013/06/24 19:00:37, Yury Semikhatsky wrote:
And this? I'd think that it is either oddball or some object as both
fields are
initialized with OddBall values in
https://code.google.com/p/chromium/codesearch#chromium/src/v8/src/heap.cc&q=AllocateAccessorPair&sq=package:chromium&type=cs&l=2360
Done.
https://codereview.chromium.org/17616002/diff/1/src/heap-snapshot-generator.cc#newcode1415
src/heap-snapshot-generator.cc:1415: if (getter && !getter->IsOddball())
{
On 2013/06/24 19:00:37, Yury Semikhatsky wrote:
Ditto.
Done.
https://codereview.chromium.org/17616002/diff/1/src/heap-snapshot-generator.cc#newcode1419
src/heap-snapshot-generator.cc:1419: if (setter && !setter->IsOddball())
{
On 2013/06/24 19:00:37, Yury Semikhatsky wrote:
Ditto.
Done.
https://codereview.chromium.org/17616002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
