On 2013/06/26 08:23:01, Jakob wrote:
High-level comments:
• Why do we need an option to turn off -fpic in the first place? Does it
really
default to on in any toolchain?
• Note that this patch as implemented will only affect standalone V8
builds.
It
won't have any effect on V8 embedded into Chrome.
As for the patch itself:
I don't think "atom=true" is an intuitive way to turn off PIC, and I
don't see
why this option should be implemented only for standalone ia32 Android
builds.
PIC is neither Atom nor ia32 nor Android specific.
Let's make the Makefile option's syntax "pic=off", map that to a GYP
variable
called 'pic', which defaults to "default" and when set to "off" adds the
-fno-pic flag directly in standalone.gypi, regardless of v8_target_arch
and
whether building for Android or not.
Hi, thanks for your comments. To my understanding, pic is a default cflag. I
just want to give an option to turn off it for atom, since pic brings
overhead
on atom, due to indirectly access to global/static variables and non-static
functions. This is somewhat specific to atom. Yes, we may do this for atom
on
other OSs using cflags. Currently I just tested android.
Suggestions and comments are welcome.
BTW, I know this patch only affects standalone V8. Will chrome fetches v8
code
from time to time?
https://codereview.chromium.org/17814002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
