On 2013/06/26 09:03:51, Lijuan Xiao wrote:
Hi, thanks for your comments. To my understanding, pic is a default cflag.
I find that surprising. FWIW we set -fPIC manually for shared library builds
(grep for it in standalone.gypi).
I just want to give an option to turn off it for atom, since pic brings
overhead
on atom, due to indirectly access to global/static variables and
non-static
functions. This is somewhat specific to atom.
The impact may be bigger on Atom, but AFAIK the way PIC works is not
specific to
any platform.
Yes, we may do this for atom on
other OSs using cflags. Currently I just tested android.
Suggestions and comments are welcome.
Well, see my first reply for suggestions.
BTW, I know this patch only affects standalone V8. Will chrome fetches v8
code
from time to time?
Sure, we roll V8 into Chrome frequently, but Chrome doesn't use any of the
files
this patch is touching. It just depends on V8's tools/gyp/v8.gyp and
manages all
compiler flags itself (see Chromium's build/common.gypi).
https://codereview.chromium.org/17814002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
