On 2013/06/25 16:22:17, Peter Rybin wrote:
On 2013/06/25 14:49:03, Yang wrote:
> On 2013/06/25 14:36:36, Peter Rybin wrote:
> > Hi Yang
> >
> > This is a follow-up change for updating local scope algorithm.
Unfortunately,
> I
> > named my variables very misleading and stealthily swapped them.
> >
> > This change does not alter behavior.
> >
> > Peter
>
> I'm confused.
>
> In runtime.cc, array element 1 is set i to be local_scope_after, and
array
> element 2 is set to be local_scope.
> In mirror-debugger, array element 1 is used as local_scope_on_stack, and
> array_element 2 is used as local_scope_modified.
>
> Wouldn't that be wrong?
That's exactly where it's misleading. "After" doesn't mean "working values
after
evaluation". "After" means "control copy of stack locals, made after
evaluation".
So I materialize stack variables before execution, then materialize them
after
execution (call "control copy" now), and this way I notice that stack
locals
haven't change and decide how to manually update them.
I introduced new names now.
I see now. I think I misunderstood the previous CL then.
How about not using MaterializeLocalScopeWithFrameInspector re-materialize a
local scope object for the control copy, but use Copy (handles.cc) instead?
Other than that, LGTM!
https://codereview.chromium.org/17644013/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
