On 2013/06/26 15:21:20, Peter Rybin wrote:
> How about not using MaterializeLocalScopeWithFrameInspector
re-materialize a
> local scope object for the control copy, but use Copy (handles.cc)
instead?
>
> Other than that, LGTM!
You choose. The way it is done now is unexpectedly more natural: we probe
actual
state of locals immediately before our compare-and-update routine. This is
more
accurate and allows for magically changed locals :)
Hm. I guess you are right. I was thinking using Copy should give the same
results, but is cheaper than MaterializeLocalScopeWithFrameInspector. Then
again
we don't care about performance in this case anyways.
https://codereview.chromium.org/17644013/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
