Hi Ben, just a cupla questions.
--Michael
https://codereview.chromium.org/17872002/diff/1/test/mjsunit/elements-kind.js
File test/mjsunit/elements-kind.js (right):
https://codereview.chromium.org/17872002/diff/1/test/mjsunit/elements-kind.js#newcode226
test/mjsunit/elements-kind.js:226: try {} catch (e) {} // TODO(titzer):
DisableOptimization
What is the timeframe to bring these back to allow optimization, I ask
because it looks like the intent of this test is to verify that things
work as expected in the full codegen and crankshaft cases. If we don't
test the crankshaft case, regressions could slip in. Is there another
way to achieve what you are looking for, like making a copy of this test
and specifying different flags?
https://codereview.chromium.org/17872002/diff/1/test/mjsunit/opt-elements-kind.js
File test/mjsunit/opt-elements-kind.js (right):
https://codereview.chromium.org/17872002/diff/1/test/mjsunit/opt-elements-kind.js#newcode29
test/mjsunit/opt-elements-kind.js:29: // Flags:
--notrack_allocation_sites
In these new tests, why do you have to turn off tracking allocation
sites?
https://codereview.chromium.org/17872002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
