Reviewers: Jakob,

Message:
It seems that we could use #if directly when using the V8_TARGET_ARCH_${arch}
and V8_HOST_ARCH_${arch}. As once those macro is defined, they are always
defined to be 1.
  1) Defined from gyp: -DV8_TARGET_ARCH_${arch}, it is 1 from gcc manual
(http://gcc.gnu.org/onlinedocs/gcc/Preprocessor-Options.html#Preprocessor-Options):
  2) From globals.h: It is 1 if detected.

Description:
Clean up the usage of V8_TARGET_ARCH_${arch} and V8_HOST_ARCH_${arch}

Please review this at https://codereview.chromium.org/18037002/

SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/

Affected files:
  M     src/arm/assembler-arm.cc
  M     src/arm/builtins-arm.cc
  M     src/arm/code-stubs-arm.cc
  M     src/arm/codegen-arm.cc
  M     src/arm/constants-arm.cc
  M     src/arm/cpu-arm.cc
  M     src/arm/debug-arm.cc
  M     src/arm/disasm-arm.cc
  M     src/arm/frames-arm.cc
  M     src/arm/full-codegen-arm.cc
  M     src/arm/ic-arm.cc
  M     src/arm/macro-assembler-arm.cc
  M     src/arm/regexp-macro-assembler-arm.cc
  M     src/arm/simulator-arm.cc
  M     src/arm/stub-cache-arm.cc
  M     src/assembler.cc
  M     src/atomicops.h
  M     src/code-stubs.h
  M     src/execution.h
  M     src/flags.cc
  M     src/frames.cc
  M     src/full-codegen.h
  M     src/gdb-jit.cc
  M     src/globals.h
  M     src/heap.h
  M     src/heap.cc
  M     src/hydrogen-instructions.cc
  M     src/hydrogen.cc
  M     src/ia32/assembler-ia32.cc
  M     src/ia32/builtins-ia32.cc
  M     src/ia32/code-stubs-ia32.cc
  M     src/ia32/codegen-ia32.cc
  M     src/ia32/cpu-ia32.cc
  M     src/ia32/debug-ia32.cc
  M     src/ia32/deoptimizer-ia32.cc
  M     src/ia32/disasm-ia32.cc
  M     src/ia32/frames-ia32.cc
  M     src/ia32/full-codegen-ia32.cc
  M     src/ia32/ic-ia32.cc
  M     src/ia32/lithium-codegen-ia32.cc
  M     src/ia32/lithium-gap-resolver-ia32.cc
  M     src/ia32/lithium-ia32.cc
  M     src/ia32/macro-assembler-ia32.cc
  M     src/ia32/regexp-macro-assembler-ia32.cc
  M     src/ia32/stub-cache-ia32.cc
  M     src/isolate.h
  M     src/isolate.cc
  M     src/mips/assembler-mips.cc
  M     src/mips/builtins-mips.cc
  M     src/mips/code-stubs-mips.cc
  M     src/mips/codegen-mips.cc
  M     src/mips/constants-mips.cc
  M     src/mips/cpu-mips.cc
  M     src/mips/debug-mips.cc
  M     src/mips/disasm-mips.cc
  M     src/mips/frames-mips.cc
  M     src/mips/full-codegen-mips.cc
  M     src/mips/ic-mips.cc
  M     src/mips/macro-assembler-mips.cc
  M     src/mips/regexp-macro-assembler-mips.cc
  M     src/mips/simulator-mips.cc
  M     src/mips/stub-cache-mips.cc
  M     src/platform-linux.cc
  M     src/platform-macos.cc
  M     src/platform-openbsd.cc
  M     src/platform-posix.cc
  M     src/platform-tls-mac.h
  M     src/platform-win32.cc
  M     src/strtod.cc
  M     src/v8utils.h
  M     src/x64/assembler-x64.cc
  M     src/x64/builtins-x64.cc
  M     src/x64/code-stubs-x64.cc
  M     src/x64/codegen-x64.cc
  M     src/x64/cpu-x64.cc
  M     src/x64/debug-x64.cc
  M     src/x64/deoptimizer-x64.cc
  M     src/x64/disasm-x64.cc
  M     src/x64/frames-x64.cc
  M     src/x64/full-codegen-x64.cc
  M     src/x64/ic-x64.cc
  M     src/x64/lithium-codegen-x64.cc
  M     src/x64/lithium-gap-resolver-x64.cc
  M     src/x64/lithium-x64.cc
  M     src/x64/macro-assembler-x64.cc
  M     src/x64/regexp-macro-assembler-x64.cc
  M     src/x64/stub-cache-x64.cc
  M     test/cctest/test-hashing.cc
  M     test/cctest/test-lockers.cc
  M     test/cctest/test-macro-assembler-x64.cc
  M     test/cctest/test-regexp.cc


--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.


Reply via email to