Reviewers: danno,
Description:
Add templatized Run() method for Hydrogen phases.
Depends upon https://codereview.chromium.org/17657004
[email protected]
BUG=
Please review this at https://codereview.chromium.org/18034003/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/hydrogen.h
M src/hydrogen.cc
Index: src/hydrogen.cc
diff --git a/src/hydrogen.cc b/src/hydrogen.cc
index
0e6e8681279f4075a4a74430f8a9d759ce775734..04debfadde9524bed82687b48142191ea8d538fc
100644
--- a/src/hydrogen.cc
+++ b/src/hydrogen.cc
@@ -4014,10 +4014,7 @@ bool HGraph::Optimize(SmartArrayPointer<char>*
bailout_reason) {
if (FLAG_use_canonicalizing) Canonicalize();
- if (FLAG_use_gvn) {
- HGlobalValueNumberingPhase phase(this);
- phase.Run();
- }
+ if (FLAG_use_gvn) Run<HGlobalValueNumberingPhase>();
if (FLAG_use_range) {
HRangeAnalysis rangeAnalysis(this);
Index: src/hydrogen.h
diff --git a/src/hydrogen.h b/src/hydrogen.h
index
277448914d2379ff24b638ca516d9925920c116f..97c9a6a21b1ffe9a0fefc8428c9ea1954515294f
100644
--- a/src/hydrogen.h
+++ b/src/hydrogen.h
@@ -427,6 +427,9 @@ class HGraph: public ZoneObject {
HConstant* GetConstant(SetOncePointer<HConstant>* pointer,
int32_t integer_value);
+ template<class Phase>
+ void Run() { Phase phase(this); phase.Run(); }
+
void MarkLive(HValue* ref, HValue* instr, ZoneList<HValue*>* worklist);
void MarkLiveInstructions();
void RemoveDeadInstructions();
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
