https://codereview.chromium.org/18053004/diff/2001/src/cpu-profiler-inl.h
File src/cpu-profiler-inl.h (right):
https://codereview.chromium.org/18053004/diff/2001/src/cpu-profiler-inl.h#newcode78
src/cpu-profiler-inl.h:78: void
ProfilerEventsProcessor::Enqueue(CodeEventsContainer* event) {
The argument should be "const CodeEventsContainer&". You could set order
on the enqueued entry only to avoid modifying const object.
https://codereview.chromium.org/18053004/diff/2001/src/cpu-profiler.cc
File src/cpu-profiler.cc (right):
https://codereview.chromium.org/18053004/diff/2001/src/cpu-profiler.cc#newcode230
src/cpu-profiler.cc:230: const char* comment) {
comment -> name?
https://codereview.chromium.org/18053004/diff/2001/src/cpu-profiler.h
File src/cpu-profiler.h (right):
https://codereview.chromium.org/18053004/diff/2001/src/cpu-profiler.h#newcode151
src/cpu-profiler.h:151: INLINE(bool running()) { return running_; }
I don't see much sense in marking these methods inline or always
inlined. Let the compiler decide what is optimal.
https://codereview.chromium.org/18053004/diff/2001/src/cpu-profiler.h#newcode251
src/cpu-profiler.h:251: INLINE(static bool
FilterOutCodeCreateEvent(Logger::LogEventsAndTags tag));
I'd rather make it a static function in cpu-profiler.cc
https://codereview.chromium.org/18053004/diff/2001/src/profile-generator.cc
File src/profile-generator.cc (right):
https://codereview.chromium.org/18053004/diff/2001/src/profile-generator.cc#newcode837
src/profile-generator.cc:837:
profiles->NewCodeEntry(Logger::FUNCTION_TAG,
Revert?
https://codereview.chromium.org/18053004/diff/2001/src/profile-generator.h
File src/profile-generator.h (right):
https://codereview.chromium.org/18053004/diff/2001/src/profile-generator.h#newcode324
src/profile-generator.h:324: const char* GetFunctionName(const char*
name) {
Can we keep these methods private and do the econversion in the
NewCodeEntry method?
Also it seems that we can get rid of GetGunctionName and leave simply
GetName. This can be done in a separate CL though.
https://codereview.chromium.org/18053004/diff/2001/src/profile-generator.h#newcode332
src/profile-generator.h:332: INLINE(CodeEntry* NewCodeEntry(
Any reasons to make it inline?
https://codereview.chromium.org/18053004/diff/2001/test/cctest/test-cpu-profiler.cc
File test/cctest/test-cpu-profiler.cc (right):
https://codereview.chromium.org/18053004/diff/2001/test/cctest/test-cpu-profiler.cc#newcode211
test/cctest/test-cpu-profiler.cc:211: frame1_code->address() + 0x10);
frame1_code->address() + 0x10 -> (frame1_code->instruction_start() +
frame1_code->instruction_end()) / 2? Otherwise, it is unclear what these
magic numbers mean.
https://codereview.chromium.org/18053004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
