https://codereview.chromium.org/18053004/diff/2001/src/cpu-profiler.cc
File src/cpu-profiler.cc (right):
https://codereview.chromium.org/18053004/diff/2001/src/cpu-profiler.cc#newcode230
src/cpu-profiler.cc:230: const char* comment) {
On 2013/06/28 11:33:43, Yury Semikhatsky wrote:
comment -> name?
Done.
https://codereview.chromium.org/18053004/diff/2001/src/cpu-profiler.h
File src/cpu-profiler.h (right):
https://codereview.chromium.org/18053004/diff/2001/src/cpu-profiler.h#newcode151
src/cpu-profiler.h:151: INLINE(bool running()) { return running_; }
On 2013/06/28 11:33:43, Yury Semikhatsky wrote:
I don't see much sense in marking these methods inline or always
inlined. Let
the compiler decide what is optimal.
Done.
https://codereview.chromium.org/18053004/diff/2001/src/cpu-profiler.h#newcode251
src/cpu-profiler.h:251: INLINE(static bool
FilterOutCodeCreateEvent(Logger::LogEventsAndTags tag));
On 2013/06/28 11:33:43, Yury Semikhatsky wrote:
I'd rather make it a static function in cpu-profiler.cc
Done.
https://codereview.chromium.org/18053004/diff/2001/src/profile-generator.cc
File src/profile-generator.cc (right):
https://codereview.chromium.org/18053004/diff/2001/src/profile-generator.cc#newcode837
src/profile-generator.cc:837:
profiles->NewCodeEntry(Logger::FUNCTION_TAG,
On 2013/06/28 11:33:43, Yury Semikhatsky wrote:
Revert?
Done.
https://codereview.chromium.org/18053004/diff/2001/src/profile-generator.h
File src/profile-generator.h (right):
https://codereview.chromium.org/18053004/diff/2001/src/profile-generator.h#newcode324
src/profile-generator.h:324: const char* GetFunctionName(const char*
name) {
On 2013/06/28 11:33:43, Yury Semikhatsky wrote:
Can we keep these methods private and do the econversion in the
NewCodeEntry
method?
Also it seems that we can get rid of GetGunctionName and leave simply
GetName.
This can be done in a separate CL though.
Will do that in a separate patch
https://codereview.chromium.org/18053004/diff/2001/src/profile-generator.h#newcode332
src/profile-generator.h:332: INLINE(CodeEntry* NewCodeEntry(
On 2013/06/28 11:33:43, Yury Semikhatsky wrote:
Any reasons to make it inline?
Done.
https://codereview.chromium.org/18053004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
