Drive-by nits, looks good otherwise.
https://codereview.chromium.org/17914002/diff/11001/src/hydrogen-escape-analysis.h
File src/hydrogen-escape-analysis.h (right):
https://codereview.chromium.org/17914002/diff/11001/src/hydrogen-escape-analysis.h#newcode57
src/hydrogen-escape-analysis.h:57: #endif /*
V8_HYDROGEN_ESCAPE_ANALYSIS_H_ */
nit: // instead of /*...*/
https://codereview.chromium.org/17914002/diff/11001/src/hydrogen.cc
File src/hydrogen.cc (right):
https://codereview.chromium.org/17914002/diff/11001/src/hydrogen.cc#newcode4035
src/hydrogen.cc:4035: HEscapeAnalysis escapeAnalysis(this);
nit: unix_hacker_style for variable names
https://codereview.chromium.org/17914002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
