Landing.
https://codereview.chromium.org/17914002/diff/11001/src/hydrogen-instructions.h
File src/hydrogen-instructions.h (right):
https://codereview.chromium.org/17914002/diff/11001/src/hydrogen-instructions.h#newcode5877
src/hydrogen-instructions.h:5877: : elements_kind_(elements_kind),
On 2013/06/28 12:40:55, titzer wrote:
Perhaps:
HasEscapingOperandAt(int index) { return index == 2 }
Done. As discussed offline: This will only work of the key is a known
HConstant and not a computed value. Also the key itself escapes, so it
should rather be "return index != 0". This will also require adaptation
of HLoadElements accordingly.
https://codereview.chromium.org/17914002/diff/11001/src/hydrogen-instructions.h#newcode6000
src/hydrogen-instructions.h:6000: class HStoreKeyedGeneric: public
HTemplateInstruction<4> {
On 2013/06/28 12:40:55, titzer wrote:
Also here...
For a generic store I think this won't work as the generic store will
call into ICs and/or the runtime. Also generic indicates that some weird
corner-case like accessors or prototype lookups are involved. And this
will be hard without a materialized receiver object.
https://codereview.chromium.org/17914002/diff/11001/src/hydrogen.cc
File src/hydrogen.cc (right):
https://codereview.chromium.org/17914002/diff/11001/src/hydrogen.cc#newcode3987
src/hydrogen.cc:3987:
On 2013/06/28 12:40:55, titzer wrote:
Whitespace change
Done.
https://codereview.chromium.org/17914002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
