lgtm
https://codereview.chromium.org/18316004/diff/2001/src/cpu-profiler-inl.h
File src/cpu-profiler-inl.h (right):
https://codereview.chromium.org/18316004/diff/2001/src/cpu-profiler-inl.h#newcode63
src/cpu-profiler-inl.h:63: ASSERT(false);
nit: we have UNREACHABLE(); for this. Or you could just ASSERT(entry !=
NULL).
https://codereview.chromium.org/18316004/diff/2001/src/profile-generator.h
File src/profile-generator.h (right):
https://codereview.chromium.org/18316004/diff/2001/src/profile-generator.h#newcode135
src/profile-generator.h:135: Builtins::Name builtin_id_ : 8;
Can you add a STATIC_ASSERT(Builtins::builtin_count < 256) or something
like that?
https://codereview.chromium.org/18316004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
