https://codereview.chromium.org/18316004/diff/2001/src/cpu-profiler-inl.h
File src/cpu-profiler-inl.h (right):
https://codereview.chromium.org/18316004/diff/2001/src/cpu-profiler-inl.h#newcode63
src/cpu-profiler-inl.h:63: ASSERT(false);
On 2013/07/01 12:16:06, Jakob wrote:
nit: we have UNREACHABLE(); for this. Or you could just ASSERT(entry
!= NULL).
Done.
https://codereview.chromium.org/18316004/diff/2001/src/profile-generator.h
File src/profile-generator.h (right):
https://codereview.chromium.org/18316004/diff/2001/src/profile-generator.h#newcode135
src/profile-generator.h:135: Builtins::Name builtin_id_ : 8;
On 2013/07/01 12:16:06, Jakob wrote:
Can you add a STATIC_ASSERT(Builtins::builtin_count < 256) or
something like
that?
Compilation will fail with a error like the following
../src/profile-generator.h:135:32: error:
'v8::internal::CodeEntry::builtin_id_' is too small to hold all values
of 'enum v8::internal::Builtins::Name' [-Werror]
if 8 bits is not enough to fit all enum values so there is no need in
extra check.
https://codereview.chromium.org/18316004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
