Revision: 15435
Author: [email protected]
Date: Tue Jul 2 00:21:07 2013
Log: Cleanup the default Isolate's entry stack.
This adds an ASSERT that the entry_stack_ of the Isolate is
empty upon destruction. The default Isolate is an exception
here, as it may still contain an entry stack item upon
destruction.
[email protected]
Review URL: https://codereview.chromium.org/18247004
http://code.google.com/p/v8/source/detail?r=15435
Modified:
/branches/bleeding_edge/src/isolate.cc
=======================================
--- /branches/bleeding_edge/src/isolate.cc Mon Jul 1 05:07:53 2013
+++ /branches/bleeding_edge/src/isolate.cc Tue Jul 2 00:21:07 2013
@@ -1960,6 +1960,15 @@
Isolate::~Isolate() {
TRACE_ISOLATE(destructor);
+ // The entry stack must be empty when we get here,
+ // except for the default isolate, where it can
+ // still contain up to one entry stack item
+ ASSERT(entry_stack_ == NULL || this == default_isolate_);
+ ASSERT(entry_stack_ == NULL || entry_stack_->previous_item == NULL);
+
+ delete entry_stack_;
+ entry_stack_ = NULL;
+
delete[] assembler_spare_buffer_;
assembler_spare_buffer_ = NULL;
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
