Reviewers: Jakob, loislo,
Message:
This is exactly same change as r15426 that was reverted due to UNREACHABLE
assertion failure. I removed that assert as some of the Code objects may be
filtered out by CpuProfiler and it is fine if they are not in the CodeMap.
Description:
Correctly report callstack when current function is FunctionCall builtin
When current function is FunctionCall builtin we have no reliable way to
determine its caller function (in many cases the top of the sampled stack
contains address of the caller but sometimes it does not). Instead of
dropping
the sample or its two top frames we simply mark the caller frame
as '(unresolved
function)'. It seems like a better approach that dropping whole sample as
knowing the top function and the rest of the stack the user should be able
to
figure out what the caller was.
This change adds builtin id to CodeEntry objects. It will be used later to
add
similar top frame analysis for FunctionApply and probably other builtins.
BUG=None
[email protected]
Please review this at https://codereview.chromium.org/18422003/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/cpu-profiler-inl.h
M src/cpu-profiler.h
M src/cpu-profiler.cc
M src/profile-generator-inl.h
M src/profile-generator.h
M src/profile-generator.cc
M test/cctest/test-cpu-profiler.cc
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
