> > Since HRangeAnalysisPhase is a proper CompilationPhase now, it should use
> > CompilationPhase::ShouldProduceTraceOutput() to determine whether to
produce
> > trace output, and FLAG_trace_range should go away.
>
> Of course, but this way we would be unable to trace only the range analysis
> however.

No I don't think so - see the source for ShouldProduceTraceOutput:

https://code.google.com/p/chromium/codesearch#chromium/src/v8/src/compiler.cc&q=CompilationPhase&sq=package:chromium&type=cs&l=1247

The combination '--trace-hydrogen --trace-phase="H_Range analysis"' will trace
only range analysis

It uses StrChr to see if the first character of the phase name (H in case of a
hydrogen phase) appears in FLAG_trace_phase.

https://codereview.chromium.org/18491002/

--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.


Reply via email to