On 2013/07/04 15:31:00, Benedikt Meurer wrote:
> Let's have a (FLAG_trace_range || ShouldProduceTraceOutput()) here.

IMHO we should be consistent in wrt the phase specific flags. Your proposed
change should be applied to all hydrogen phases w/ special trace flags.
Opinions?

Ok I took a closer look, you are quite right - we do not consistently use
ShouldProduceTraceOutput().
So this shouldn't block you from landing this CL, so lgtm.

https://codereview.chromium.org/18491002/

--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.


Reply via email to