Reviewers: Toon Verwaest,
Message:
Unbreak GDB macro magic after recent optimization level changes for debug
builds.
Description:
Do not inline printing functions typically used via GDB.
Please review this at https://codereview.chromium.org/19722005/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/objects-printer.cc
M src/objects.h
Index: src/objects-printer.cc
diff --git a/src/objects-printer.cc b/src/objects-printer.cc
index
0ed737be4eeca5a82f05a8fe51242ed013ed4a20..19524e21d23f2f5ee06ebac044deee41f3a36e4f
100644
--- a/src/objects-printer.cc
+++ b/src/objects-printer.cc
@@ -40,6 +40,11 @@ namespace internal {
static const char* TypeToString(InstanceType type);
+void MaybeObject::Print() {
+ Print(stdout);
+}
+
+
void MaybeObject::Print(FILE* out) {
Object* this_as_object;
if (ToObject(&this_as_object)) {
@@ -55,6 +60,11 @@ void MaybeObject::Print(FILE* out) {
}
+void MaybeObject::PrintLn() {
+ PrintLn(stdout);
+}
+
+
void MaybeObject::PrintLn(FILE* out) {
Print(out);
PrintF(out, "\n");
Index: src/objects.h
diff --git a/src/objects.h b/src/objects.h
index
5d5945ef7ca9dca0579b30cf15d8a0018ea5c55b..58a76b3d6ce3e9647cd25ef496ccde42120de033
100644
--- a/src/objects.h
+++ b/src/objects.h
@@ -922,13 +922,9 @@ class MaybeObject BASE_EMBEDDED {
#ifdef OBJECT_PRINT
// Prints this object with details.
- inline void Print() {
- Print(stdout);
- }
- inline void PrintLn() {
- PrintLn(stdout);
- }
+ void Print();
void Print(FILE* out);
+ void PrintLn();
void PrintLn(FILE* out);
#endif
#ifdef VERIFY_HEAP
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
