Reviewers: danno,
Message:
This is danno's comment on https://codereview.chromium.org/18014003. It will
apply for X32 as well.
Description:
Use kPointerSize to compute the call instruction offset in the
PatchedReturnSequence for X64
Please review this at https://codereview.chromium.org/19678009/
SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/
Affected files:
M src/x64/assembler-x64-inl.h
Index: src/x64/assembler-x64-inl.h
===================================================================
--- src/x64/assembler-x64-inl.h (revision 15744)
+++ src/x64/assembler-x64-inl.h (working copy)
@@ -369,7 +369,7 @@
// The 11th byte is int3 (0xCC) in the return sequence and
// REX.WB (0x48+register bit) for the call sequence.
#ifdef ENABLE_DEBUGGER_SUPPORT
- return pc_[10] != 0xCC;
+ return pc_[2 + kPointerSize] != 0xCC;
#else
return false;
#endif
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
