Looking good, nice catch! Just two comments about additional asserts.
https://codereview.chromium.org/19804002/diff/1/src/hydrogen-instructions.cc
File src/hydrogen-instructions.cc (right):
https://codereview.chromium.org/19804002/diff/1/src/hydrogen-instructions.cc#newcode3233
src/hydrogen-instructions.cc:3233: if (new_dominator_size >
Page::kMaxNonCodeHeapObjectSize) {
Can we add an assert here like the following? This makes sure that we
are not statically exceeding the limit for neither new-space nor
pretenured allocations.
ASSERT_LE(Page::kMaxNonCodeHeapObjectSize,
Page::kMaxObjectSizeInNewSpace);
Also on top of that, could we add asserts to MacroAssembler::Allocate
(the one that takes a static object size) that check we are not
exceeding the same limit through other call-sites? I know it's not part
of this change but such an assert would have caught this violation
earlier.
https://codereview.chromium.org/19804002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
