On 2013/07/22 12:28:04, Michael Starzinger wrote:
LGTM.
https://codereview.chromium.org/19804002/diff/1/src/hydrogen-instructions.cc
File src/hydrogen-instructions.cc (right):
https://codereview.chromium.org/19804002/diff/1/src/hydrogen-instructions.cc#newcode3233
src/hydrogen-instructions.cc:3233: if (new_dominator_size >
Page::kMaxNonCodeHeapObjectSize) {
On 2013/07/22 08:46:07, Michael Starzinger wrote:
> Can we add an assert here like the following? This makes sure that we
are
not
> statically exceeding the limit for neither new-space nor pretenured
allocations.
>
> ASSERT_LE(Page::kMaxNonCodeHeapObjectSize,
Page::kMaxObjectSizeInNewSpace);
>
> Also on top of that, could we add asserts to MacroAssembler::Allocate
(the
one
> that takes a static object size) that check we are not exceeding the
same
limit
> through other call-sites? I know it's not part of this change but such
an
assert
> would have caught this violation earlier.
As discussed offline: This is a can of worms and we will clean it up in a
followup CL where we'll try to unify those two constant.
committed, Revision: r15804
https://codereview.chromium.org/19804002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
